Skip to content

chore: add STL and USD formats to Git LFS tracking#709

Open
jiwenc-nv wants to merge 1 commit into
NVIDIA:mainfrom
jiwenc-nv:jiwenc/git-lfs-3d
Open

chore: add STL and USD formats to Git LFS tracking#709
jiwenc-nv wants to merge 1 commit into
NVIDIA:mainfrom
jiwenc-nv:jiwenc/git-lfs-3d

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Jun 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

add STL and USD formats to Git LFS tracking
Fixes #(issue)

Type of change

  • Code base chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • Chores
    • Expanded support for additional 3D asset file formats in Git-based storage, including common model and USD variants.
    • Added coverage for uppercase STL files to improve consistency across filesystems and workflows.

@jiwenc-nv
chore: add STL and USD formats to Git LFS tracking
b3be70e 
Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

📝 Docs preview is not auto-deployed for fork PRs.

A maintainer with write access to NVIDIA/IsaacTeleop can deploy a preview by
commenting /preview-docs on this PR. Once deployed, the preview
will live at:

https://nvidia.github.io/IsaacTeleop/preview/pr-709/

@jiwenc-nv jiwenc-nv requested a review from nv-jakob June 26, 2026 04:39
@coderabbitai

coderabbitai Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c644bb41-eaca-47bb-994a-7f2a94b08935

📥 Commits

Reviewing files that changed from the base of the PR and between c344ab9 and b3be70e.

📒 Files selected for processing (1)
  • .gitattributes
📝 Walkthrough

Walkthrough

.gitattributes adds Git LFS filter, diff, and merge rules for .obj, .stl, .STL, .usd, .usda, .usdc, and .usdz, along with a comment describing the tracked 3D asset types.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change by adding STL and USD formats to Git LFS tracking.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

nv-jakob
nv-jakob approved these changes Jun 26, 2026
View reviewed changes

@nv-jakob nv-jakob left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nv-jakob nv-jakob nv-jakob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiwenc-nv @nv-jakob